mili support in ParaView 5.8.1-RC1 is broken as it is dependent on missing rapidjson

Development
1

Hi,

mili support in ParaView 5.8.1-RC1 is broken as it is dependent on rapidjson which
while included at one point in the superbuild (rapidjson-1.1.0.tar.gz) git master is not
included in the ParaView 5.8.1-RC1 tag version.

Thanks,

Joe Hennessey

2

Hi Joe,
Is mili in Master?

Alan

3

CLASSIFICATION: UNCLASSIFIED

Alan,

Yes, mili is in the master paraview superbuild (see lines 192-194 of versions.cmake from the top level of the superbuild)

if you use

-DENABLE_mili=ON

It will attempt to build it.

mili itself will build but then the superbuild will fail during the paraview build, where it is integrated with paraview.

where it can not find the rapidjson headers (as rapidjson is no longer there)

Thanks,

Joe

4

Did this work in 5.8.0?

5.8.1 is basically cooked, cooled off, and sitting on the dinning room table. Very likely not going to happen there. 5.8.1 is primarily a bug fix release, off of 5.8.0.

We should get this fixed for 5.9.0. Please write up a bug in the git bugtracker? Add a link to it in this discussion.

5

Hi Joe,

The binaries of ParaView 5.8.1-RC1 on paraview.org have the mili reader working on macOS and linux, the two platforms that currently have the mili reader.

Do you have the v5.8.1-RC1 tag of the superbuild checked out?

6

CLASSIFICATION: UNCLASSIFIED

Cory,

Yes, I have the v5.8.1-RC1 tag of the superbuild checked out.

Here is the location of the problems origin.

Lines 122-131 of the file superbuild/paraview/src/Utilities/VisItBridge/databases/CMakeLists.txt

visit_include_reader_source(Mili OFF)
if(VISIT_BUILD_READER_Mili)
  vtk_module_find_package(PACKAGE Mili)
  vtk_module_find_package(PACKAGE RapidJSON)
  list(APPEND visit_libraries
    Mili::Mili
    rapidjson)
  list(APPEND visit_readers_xmls
    visit_mili_reader.xml)
endif()

Since rapidjson is no longer in the superbuild this causes the problem.

Thanks,

Joe

7

CLASSIFICATION: UNCLASSIFIED

Alan,

I have created a ParaView Superbuild issue to track this.

https://gitlab.kitware.com/paraview/paraview-superbuild/-/issues/160

Here is the location of the problems origin.

Lines 122-131 of the file superbuild/paraview/src/Utilities/VisItBridge/databases/CMakeLists.txt

visit_include_reader_source(Mili OFF)
if(VISIT_BUILD_READER_Mili)
  vtk_module_find_package(PACKAGE Mili)
  vtk_module_find_package(PACKAGE RapidJSON)
  list(APPEND visit_libraries
    Mili::Mili
    rapidjson)
  list(APPEND visit_readers_xmls
    visit_mili_reader.xml)
endif()

Since rapidjson is no longer in the superbuild this causes the problem.

Thanks,

Joe

8

Cory,

I had it set to

-Dparaview_SOURCE_SELECTION=“git”

I have now set it to

-Dparaview_SOURCE_SELECTION="5.8.1-RC1”

That was the source of the problem, I was using the superbuild for 5.8.1-RC1,
but the ParaView source from the git master branch, instead of the 5.8.1-RC1 tag.

Sorry for the confusion. It is compiling ok now. I will close the issue.

Thanks,

Joe

9

FYI, rapidjson was removed in ParaView master and indeed added for superbuild as an external project to support mili here