The color of menus

Development
1

Hello! All main menus, such as File, Edit, View, Objects e.t.c. have actions of white color. The actions in Filters and Extractors have gray color, the same as color as the panel with menus. Why are they different? Can I make them all of gray color?

2

Do you mean everything is grayed out ?

Please share a screenshot.

3

I believe what @jeDuck is referring to is that in 5.13, some of the drop-down menus use different background colors:

For example, the Sources menu has a color of #ffffff

image
image974Ă—661 35.4 KB

While Filters menu has a background color of #f0f0f0

image
image791Ă—592 31 KB

I think this has been fixed in 6.0 however?

4

I replicated this issue. It is in 5.13.1, only windows. Mac and Linux don’t show it. It is fixed in 6.0.0.

5

I checked it in Paraview 6.0, windows 10, and the menus still have different color:

  1. Filters menu, color #f0f0f0
    image
    image1941Ă—1042 125 KB
  2. Sources menu, color #ffffff
    image
    image1917Ă—1040 73.6 KB
6

Hum, one menu is dynamic, the others are not. Is Filters menu different from all other menus ?

FYI @nicolas.vuaille

7

Both menu are generated in a very similar way. Also we do not specify any custom color in this code path so I have no idea.

1 Like
8

I found the difference. In pqParaViewMenuBuilders the “Filters” and “Extractors” menus call
menu.setStyle(new pqActiveDisabledStyle)

Those two menus are the only ones that are gray.
If you comment this line, the menus become white.
I don’t quite understand what this line does and how to fix that though

9

Good catch !

I think I understand the issue, I’ll let you know. Thanks for reporting!

10

@jeDuck which version of Qt are you using when building ParaView?

11

ParaView 6.0, the screenshots of which I provided earlier, is not a build, I downloaded the binaries.

For my development I use Qt 5.15.2

12

Can you try to remove the style override in the menu builder as follow please?

diff --git a/Qt/ApplicationComponents/pqParaViewMenuBuilders.cxx b/Qt/ApplicationComponents/pqParaViewMenuBuilders.cxx
index 2e271bfb1d..3f187945d8 100644
--- a/Qt/ApplicationComponents/pqParaViewMenuBuilders.cxx
+++ b/Qt/ApplicationComponents/pqParaViewMenuBuilders.cxx
@@ -124,14 +124,6 @@
 class pqActiveDisabledStyle : public QProxyStyle
 {
 public:
-  pqActiveDisabledStyle()
-#if QT_VERSION >= QT_VERSION_CHECK(6, 1, 0)
-    : QProxyStyle(QStyleFactory::create(QApplication::style()->name()))
-#else
-    : QProxyStyle(QStyleFactory::create("fusion"))
-#endif
-  {
-  }
 
   ~pqActiveDisabledStyle() override = default;